Add the vendor directory to .gitignore
#786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* gardener#748 removed the `vendor` directory from `etcd-druid` and makes the project rely on the module cache set up by the `go` tool for finding dependencies. * However, there are use cases where for better developer experience, it would make sense to have the dependencies reside in the same project folder as `etcd-druid`, so that tokens can be searched for, using project wide search in any text editor. Results can be fetched from the dependencies, without having to rely on the LSP. For example, this would make looking at all usages of a constant that is defined by a dependency easier. * The developer can simply run `go mod vendor` without it affecting the modified build process which doesn't use `vendor`, as defined in gardener#748.
gardener-robot
added
area/dev-productivity
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
gardener-robot
added
the
reviewed/do-not-merge
gardener-robot-ci-3
added
reviewed/ok-to-test
|
Can be merged once #777 merges. |
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area dev-productivity
/kind enhancement
What this PR does / why we need it:
#748 removed the
vendordirectory frometcd-druidand makes the project rely on the module cache set up by thegotool for finding dependencies.However, there are use cases where for better developer experience, it would make sense to have the dependencies reside in the same project folder as
etcd-druid, so that tokens can be searched for, using project wide search in any text editor. Results can be fetched from the dependencies, without having to rely on the LSP. For example, this would make looking at all usages of a constant that is defined by a dependency easier.The developer can simply run
go mod vendorwithout it affecting the modified build process which doesn't usevendor, as defined in #748.However, to not break the current build process which doesn't use the
vendordirectory anymore, rename thevendordirectory to anything else while runningmake runormake docker-build(mv vendor .vendorfor example).Special notes for your reviewer:
/hold till #777 merges.