Add support for overriding storage API endpoint for GCS #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot
added
area/backup
gardener-robot-ci-3
added
reviewed/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
shreyas-s-rao
added
needs/cherry-pick
shreyas-s-rao
force-pushed
the
enh/gcs-rep
branch
from
35ef2c9 to
29e83b2
Compare
gardener-robot
added
size/xl
gardener-robot-ci-2
added
reviewed/ok-to-test
|
/retest |
|
/assign @seshachalam-yv |
|
/assign |
|
@seshachalam-yv, @ishan16696 You have pull request review open invite, please check |
seshachalam-yv
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
Thanks @shreyas-s-rao for introducing new constants for env vars.
Overall looks good to me.
Nice PR ❤️
/lgtm
gardener-robot
removed
needs/review
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot
added
needs/second-opinion
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
|
/test pull-etcd-druid-e2e-kind |
ishan16696
approved these changes
Dec 24, 2023
|
/test pull-etcd-druid-e2e-kind |
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area backup
/kind enhancement
/platform gcp
What this PR does / why we need it:
Add support for overriding storage API endpoint for Google GCS provider. This allows users to specify their own storage API endpoint override, such as a regional endpoint, or even a local GCS emulator endpoint. Users need to add a new field
storageAPIEndpointin their GCS backup secret, with the value in the formathttp[s]://host[:port]/storage/v1/, to utilise this feature.Additionally, clean up some of the code and reduce duplicate code:
controllers/compaction.getCompactionJobEnvVar()andpkg/component/etcd/statefulset.getBackupRestoreEnvVars()intopkg/utils.GetBackupRestoreContainerEnvVars()underpkg/utils/envvar.go, along with associated helper functionspkg/common/constants.goto the formatEnv*with correct camel casing, and use inpkg/utils.GetBackupRestoreContainerEnvVars()Which issue(s) this PR fixes:
Fixes #736
Special notes for your reviewer:
/cc @dguendisch @anveshreddy18
/invite @ishan16696 @seshachalam-yv
Release note: