Documentation for all controllers of etcd-druid #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
gardener-robot
added
area/documentation
|
Thank you @renormalize for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below. |
shreyas-s-rao
requested changes
Dec 1, 2023
There was a problem hiding this comment.
@renormalize thanks for the well-written PR, and for documenting the design and functionality of the controllers in a concise way. I have left some suggestions for improvements. PTAL.
gardener-robot
added
size/xl
gardener-robot-ci-1
added
reviewed/ok-to-test
renormalize
changed the base branch from
master
to
enhancements.etcd-druid-v070
renormalize
changed the base branch from
enhancements.etcd-druid-v070
to
master
* Documents all controllers of etcd-druid in docs/concepts/00-controllers.md * Explains the usage of Kubebuilder * Explains the package structure * Introduces the *controller manager* * Briefly explains the 5 controllers
* Changed the file name to docs/concepts/controllers.md * Added all suggestions to the content for each controller
renormalize
force-pushed
the
document-controllers
branch
from
d6c928d to
bdb9a37
Compare
gardener-robot
added
size/m
gardener-robot-ci-2
added
reviewed/ok-to-test
shreyas-s-rao
requested changes
Dec 14, 2023
There was a problem hiding this comment.
@renormalize thanks a lot for making all the requested changes! Just couple more nits, but overall LGTM 👍
* Removed unecessary comment. * Grammar fix in line 53.
gardener-robot-ci-1
added
reviewed/ok-to-test
shreyas-s-rao
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
@renormalize thanks for addressing all my comments. LGTM!
/lgtm
gardener-robot
added
reviewed/lgtm
|
/retest |
gardener-robot-ci-3
added
the
reviewed/ok-to-test
ishan16696
reviewed
Dec 19, 2023
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot-ci-3
added
reviewed/ok-to-test
ishan16696
approved these changes
Dec 21, 2023
|
/retest |
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area documentation
/kind enhancement
What this PR does / why we need it:
Documentation for the 5 controllers of etcd-druid
docs/concepts/controllers.mdWhich issue(s) this PR fixes:
Fixes #695
Special notes for your reviewer:
Due to the planned changes to the
etcdandcustodiancontrollers, the documentation for those two is not complete at the moment.Release note: