Extend Etcd CRD to include DeltaSnapshotRetentionPeriod field

gardener · Jul 29, 2023 · 524e4e9 · 524e4e9
1 parent b4d722f
commit 524e4e9
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 0 deletions.
diff --git a/api/v1alpha1/types_etcd.go b/api/v1alpha1/types_etcd.go
@@ -178,6 +178,12 @@ type BackupSpec struct {
 	// DeltaSnapshotMemoryLimit defines the memory limit after which delta snapshots will be taken
 	// +optional
 	DeltaSnapshotMemoryLimit *resource.Quantity `json:"deltaSnapshotMemoryLimit,omitempty"`
+	// DeltaSnapshotRetentionPeriod defines the duration to retain old delta snapshots. Delta snapshots within this
+	// duration will not be deleted. This provides more flexibility for backup retention by allowing older delta snapshots
+	// to be preserved.
+	// +optional
+	DeltaSnapshotRetentionPeriod *metav1.Duration `json:"deltaSnapshotRetentionPeriod,omitempty"`
+
 	// SnapshotCompression defines the specification for compression of Snapshots.
 	// +optional
 	SnapshotCompression *CompressionSpec `json:"compression,omitempty"`

diff --git a/charts/druid/charts/crds/templates/10-crd-druid.gardener.cloud_etcds.yaml b/charts/druid/charts/crds/templates/10-crd-druid.gardener.cloud_etcds.yaml
@@ -146,6 +146,10 @@ spec:
                     description: DeltaSnapshotPeriod defines the period after which
                       delta snapshots will be taken
                     type: string
+                  deltaSnapshotRetentionPeriod:
+                    description: "The retention period for delta snapshots, excluding the latest snapshot set. The value should be a string formatted as a duration (e.g., '1s', '2m', '3h', '4d'). The minimum value is 1 second."
+                    type: string
+                    pattern: ^([1-9][0-9]*([.][0-9]+)?(s|m|h|d))+$
                   enableProfiling:
                     description: EnableProfiling defines if profiling should be enabled
                       for the etcd-backup-restore-sidecar

diff --git a/config/crd/bases/10-crd-druid.gardener.cloud_etcds.yaml b/config/crd/bases/10-crd-druid.gardener.cloud_etcds.yaml
@@ -146,6 +146,10 @@ spec:
                     description: DeltaSnapshotPeriod defines the period after which
                       delta snapshots will be taken
                     type: string
+                  deltaSnapshotRetentionPeriod:
+                    description: "The retention period for delta snapshots, excluding the latest snapshot set. The value should be a string formatted as a duration (e.g., '1s', '2m', '3h', '4d'). The minimum value is 1 second."
+                    type: string
+                    pattern: ^([1-9][0-9]*([.][0-9]+)?(s|m|h|d))+$
                   enableProfiling:
                     description: EnableProfiling defines if profiling should be enabled
                       for the etcd-backup-restore-sidecar