Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rel-v0.30] Backup-restore now restart the etcd member incase of etcd's advertise peerURL found to be updated. #794

Merged
merged 1 commit into from
Oct 17, 2024
Merged

[rel-v0.30] Backup-restore now restart the etcd member incase of etcd's advertise peerURL found to be updated. #794

merged 1 commit into from
Oct 17, 2024

Conversation

ishan16696
Copy link
Member

What this PR does / why we need it:
Cherry-pick PR of #788

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

etcd-backup-restore now triggers a restart of the etcd member after updating etcd's advertise peer URLs if found updated.

Introduced a CLI flag `--use-etcd-wrapper` (default: false) to enable/disable the backup-restore to use etcd-wrapper related functionality. Note: enable this flag only if etcd-wrapper is deployed.

@ishan16696 @unmarshall @shreyas-s-rao
Backup-restore now restart the etcd member incase of etcd's advertise…
9143a9e 
… peerURL found to be updated. (gardener#788)

Fix for comparing member Peer URLs before updating and invoking stop wrapper endpoint
Added a CLI flag:`--use-etcd-wrapper` to server sub-command.

Co-authored-by: madhav bhargava <[email protected]>
Co-authored-by: Shreyas Rao <[email protected]>
@ishan16696 ishan16696 requested a review from a team as a code owner October 17, 2024 04:13
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Oct 17, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 17, 2024
unmarshall
unmarshall approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@unmarshall unmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 17, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 17, 2024
@ishan16696 ishan16696 merged commit 14fc3cf into gardener:rel-v0.30 Oct 17, 2024
9 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 17, 2024
@ishan16696 ishan16696 deleted the cherryPick-PR788 branch October 17, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unmarshall unmarshall unmarshall approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ishan16696 @unmarshall @gardener-robot-ci-2 @gardener-robot