Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the docker-build make target to build for multiple platforms. #780

Merged
merged 1 commit into from
Sep 24, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ REGISTRY ?= europe-docker.pkg.dev/gardener-project/snapshots
IMAGE_REPOSITORY := $(REGISTRY)/gardener/etcdbrctl
IMAGE_TAG := $(VERSION)
BUILD_DIR := build
PLATFORM ?= $(shell docker info --format '{{.OSType}}/{{.Architecture}}')
BIN_DIR := bin
COVERPROFILE := test/output/coverprofile.out

IMG ?= ${IMAGE_REPOSITORY}:${IMAGE_TAG}
IMG ?= ${IMAGE_REPOSITORY}:${IMAGE_TAG}

.DEFAULT_GOAL := build-local

Expand All @@ -34,7 +34,7 @@ build-local:

.PHONY: docker-build
docker-build:
@docker build -t ${IMG} -f $(BUILD_DIR)/Dockerfile --rm .
docker buildx build --platform=$(PLATFORM) --tag $(IMG) -f $(BUILD_DIR)/Dockerfile --rm .

.PHONY: docker-push
docker-push:
Expand Down