Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incremental/Continuous ETCD Backups #2

Closed
8 of 9 tasks
vlerenc opened this issue Feb 9, 2018 · 1 comment
Closed
8 of 9 tasks

Incremental/Continuous ETCD Backups #2

vlerenc opened this issue Feb 9, 2018 · 1 comment
Assignees
@swapnilgm
Labels
kind/enhancement Enhancement, improvement, extension platform/all
Milestone
0.3.0

Comments

@vlerenc
Copy link
Member

vlerenc commented Feb 9, 2018 •
edited by swapnilgm
Loading

Story

  • As user I want my Kubernetes cluster always to show my latest state and not "forget" resources.
  • As provider I want etcd backups to be written incrementally/continuously (with full backups now and then) so that I run a near-zero risk of infrastructure inconsistencies after backup.

Motivation

In order to make sure our ETCD backups are as fresh as possible and reflect the actual infrastructure state as good as possible, we should continue the begun work with the incremental/continuous backups.

Acceptance Criteria

  • ETCD full backups are taken regularly, e.g. every hour
  • Logs of ETCD watches are written continuously
  • Logs taken before a new ETCD full backup are deleted
  • When a restore is necessary the last ETCD full backup plus the additional ETCD logs (from the last entry in the full backup) are restored automatically

Definition of Done

  • Knowledge is distributed: Have you spread your knowledge in pair programming/code review?
  • Unit Tests are provided: Have you written automated unit tests or added manual NGPTT tickets?
  • Integration Tests are provided: Have you written automated integration tests?
  • Minimum API exposure: If you have added public API, was it really necessary/is it minimal?
  • Operations guide: Have you updated the operations guide?
@vlerenc vlerenc mentioned this issue Feb 11, 2018
Closed
@swapnilgm swapnilgm self-assigned this May 29, 2018
@swapnilgm swapnilgm added this to the 0.3.0 milestone May 31, 2018
@swapnilgm swapnilgm added kind/enhancement Enhancement, improvement, extension status/in-progress Issue is in progress/work platform/all labels May 31, 2018
@swapnilgm swapnilgm mentioned this issue Jun 5, 2018
Merged
@swapnilgm
Copy link
Contributor

Feature added in #29

@ccwienk ccwienk removed the status/in-progress Issue is in progress/work label Aug 18, 2018
renormalize added a commit to renormalize/etcd-backup-restore that referenced this issue Nov 16, 2023
@renormalize
Addressed review comments gardener#2
53feead 
* Moved `snapStorePreviousModTime` to the `Snapshotter` `struct`
  and renamed it to `prevSecretModTime`
* Replaced invocations of `readModTime()` with `fileInfo.ModTime()`
  and thereby removing unnecessary checks in `readModTime()`
* Clearer function documentation comments for each provider specific
  credential file modification time fetching functions
* More idiomatic logging of errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swapnilgm swapnilgm

Labels
kind/enhancement Enhancement, improvement, extension platform/all
Projects
None yet
Milestone
0.3.0
Development

No branches or pull requests
3 participants
@vlerenc @swapnilgm @ccwienk