Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed gardenctl shell command usage for node debugging #398

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Removed gardenctl shell command usage for node debugging #398

merged 1 commit into from
Feb 20, 2023

Conversation

ashwani2k
Copy link
Contributor

@ashwani2k ashwani2k commented Feb 20, 2023 •
edited
Loading

What this PR does / why we need it:
The official documentation still supports usage of gardenctl shell command for node debugging.
This is no more supported with gardenctl-v2.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Documentation for shell access to a node is updated with removal of section on using `gardenctl shell` command as it is no more supported with gardenctl-v2

@ashwani2k ashwani2k requested a review from a team as a code owner February 20, 2023 04:32
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Feb 20, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 20, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 20, 2023
n-boshnakov
n-boshnakov approved these changes Feb 20, 2023
View reviewed changes
Copy link
Contributor

@n-boshnakov n-boshnakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Feb 20, 2023
@n-boshnakov n-boshnakov merged commit 2baabcf into master Feb 20, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Feb 20, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 20, 2023
@ashwani2k ashwani2k deleted the update-shell-access branch February 21, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n-boshnakov n-boshnakov n-boshnakov approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ashwani2k @n-boshnakov @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot