Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the Contributor Guide #386

Merged
merged 2 commits into from
Oct 24, 2022
Merged

Updated the Contributor Guide #386

merged 2 commits into from
Oct 24, 2022

Conversation

n-boshnakov
Copy link
Contributor

@n-boshnakov n-boshnakov commented Oct 19, 2022 •
edited
Loading

What this PR does / why we need it:
This PR updates the Contributor Guide:

  • adds new content - Images page
  • removes outdated content - Community page
  • updates existing content - Markdown and Style Guide pages, Topic templates, Community page
  • unifies the style of the Code and Documentation sections

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

added new guidelines for image creation when contributing content to the documentation

@n-boshnakov n-boshnakov requested a review from a team as a code owner October 19, 2022 10:13
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Oct 19, 2022
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 19, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 19, 2022
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 21, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 21, 2022
JordanJordanov
JordanJordanov approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@JordanJordanov JordanJordanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 24, 2022
@n-boshnakov n-boshnakov merged commit fc12186 into gardener:master Oct 24, 2022
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordanJordanov JordanJordanov JordanJordanov approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@n-boshnakov @JordanJordanov @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot