Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed remove completely link #53

Merged
merged 1 commit into from
Oct 15, 2020
Merged

fixed remove completely link #53

merged 1 commit into from
Oct 15, 2020

Conversation

g-pavlov
Copy link
Contributor

What this PR does / why we need it:
Trying to completely remove a link in a link substitute with destination:"" and text:"" wasn't working correctly. This is fixed now.

Release note:

Trying to completely remove a link in a link substitute with `destination:""` and `text:""` wasn't working correctly. This is fixed now.

@g-pavlov g-pavlov added the component/documentation Gardener Documentation label Oct 15, 2020
@g-pavlov g-pavlov self-assigned this Oct 15, 2020
@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Oct 15, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 15, 2020
@g-pavlov g-pavlov merged commit 0cca628 into master Oct 15, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 15, 2020
@g-pavlov g-pavlov deleted the fixlinkupdates branch October 15, 2020 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swilen-iwanow swilen-iwanow Awaiting requested review from swilen-iwanow

Assignees

@g-pavlov g-pavlov

Labels
component/documentation Gardener Documentation needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@g-pavlov @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot