Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove defaulting of files to md. fileTree won't load files without md suffix #357

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Remove defaulting of files to md. fileTree won't load files without md suffix #357

merged 1 commit into from
Nov 28, 2024

Conversation

Kostov6
Copy link
Contributor

@Kostov6 Kostov6 commented Nov 28, 2024

What this PR does / why we need it:
Defaulting files to .md does not provide any value so let's remove it at it is an implicit behavior. Files without extension were not skipped as they were defaulted to .md. When we don't have the defaulting logic let's just skip all files that are not .md

Release note:

Remove defaulting of files to `md`. `fileTree` won't load files without `md `suffix

@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Nov 28, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 28, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 28, 2024
RadaBDimitrova
RadaBDimitrova approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@RadaBDimitrova RadaBDimitrova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 28, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 28, 2024
@RadaBDimitrova RadaBDimitrova merged commit 918e444 into gardener:master Nov 28, 2024
10 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RadaBDimitrova RadaBDimitrova RadaBDimitrova approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Kostov6 @RadaBDimitrova @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot