Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Multi-Arch Images #286

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Build Multi-Arch Images #286

merged 1 commit into from
Jan 17, 2023

Conversation

oliver-goetz
Copy link
Member

@oliver-goetz oliver-goetz commented Jan 9, 2023 •
edited
Loading

What this PR does / why we need it:
This PR builds arm64 binaries for Linux and Darwin.
Additionally, the the CI pipeline publishes multi-arch images with support for linux/amd64 and linux/arm64 now.

Which issue(s) this PR fixes:
Fixes #280

Special notes for your reviewer:
If I understood .ci/update-release.py script correctly the new binaries should be added to the release automatically.

Release note:

Docforge release includes docforge binaries for `arm64` architecture on `Linux` and `Darwin` now.
Docker images are published with multi-arch support for `linux/amd64` and `linux/arm64` now.

@oliver-goetz oliver-goetz requested a review from a team January 9, 2023 19:48
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Jan 9, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 9, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jan 9, 2023
@oliver-goetz oliver-goetz mentioned this pull request Jan 9, 2023
Closed
29 tasks
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 9, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jan 9, 2023
@rfranzke
Copy link
Member

/cc @Kristian-ZH

Kristian-ZH
Kristian-ZH approved these changes Jan 17, 2023
View reviewed changes
Copy link

@Kristian-ZH Kristian-ZH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jan 17, 2023
@Kristian-ZH Kristian-ZH merged commit d8eb91c into gardener:master Jan 17, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jan 17, 2023
@oliver-goetz oliver-goetz deleted the enh/build-arm64 branch August 29, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kristian-ZH Kristian-ZH Kristian-ZH approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build and release arm64 binaries
7 participants
@oliver-goetz @rfranzke @Kristian-ZH @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot