Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oauth token is optional #250

Merged
merged 1 commit into from
Nov 24, 2021
Merged

oauth token is optional #250

merged 1 commit into from
Nov 24, 2021

Conversation

Kostov6
Copy link
Contributor

@Kostov6 Kostov6 commented Nov 22, 2021 •
edited
Loading

What this PR does / why we need it:
OAuth token is optional

Release note:

Docforge can run even without an OAuth token
In this configuration the rate limit is only 60

@Kostov6 Kostov6 requested a review from a team November 22, 2021 12:39
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 22, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 22, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 22, 2021
@Kostov6 Kostov6 force-pushed the oauth_token_optional branch from 9b2270a to 6552783 Compare November 22, 2021 12:50
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 22, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 22, 2021
Kristian-ZH
Kristian-ZH suggested changes Nov 22, 2021
View reviewed changes
cmd/app/cmd.go Outdated Show resolved Hide resolved
@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Nov 22, 2021
@Kristian-ZH Kristian-ZH added the needs/second-opinion Needs second review by someone else label Nov 22, 2021
@Kostov6 Kostov6 force-pushed the oauth_token_optional branch from 6552783 to f6f4b5b Compare November 22, 2021 13:34
@gardener-robot gardener-robot added size/s Size of pull request is small (see gardener-robot robot/bots/size.py) and removed size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 22, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 22, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 22, 2021
Kristian-ZH
Kristian-ZH approved these changes Nov 24, 2021
View reviewed changes
Copy link

@Kristian-ZH Kristian-ZH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review needs/second-opinion Needs second review by someone else labels Nov 24, 2021
@Kristian-ZH Kristian-ZH merged commit 6cd2495 into gardener:master Nov 24, 2021
@Kostov6 Kostov6 deleted the oauth_token_optional branch September 4, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitar-kostadinov dimitar-kostadinov dimitar-kostadinov left review comments

@Kristian-ZH Kristian-ZH Kristian-ZH approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Kostov6 @dimitar-kostadinov @Kristian-ZH @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot