Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web url to files git-data #166

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Add web url to files git-data #166

merged 1 commit into from
Feb 11, 2021

Conversation

g-pavlov
Copy link
Contributor

@g-pavlov g-pavlov commented Feb 10, 2021

What this PR does / why we need it:
Adds git commits html_url as weburl property in files' gitinfo.

Example:
With html_url in commit history like that:

{
      "sha": "2a97450d964f39ee1b320fecd4c565f83f2590eb",
      "node_id": "MDY6Q29tbWl0MTEzMDMwODQ1OjJhOTc0NTBkOTY0ZjM5ZWUxYjMyMGZlY2Q0YzU2NWY4M2YyNTkwZWI=",
      "html_url": "https://github.com/gardener/documentation/commit/2a97450d964f39ee1b320fecd4c565f83f2590eb",
...

we construct weburl in gitinfo like that:

{
    ...
    "weburl": "https://github.com/gardener/documentation",
    ...

Which issue(s) this PR fixes:
Fixes #165

Release note:

A new proprty `weburl` added to files gitinfo. It is a URL that references the repository hosting the file for which the gitinfo has been created.

@g-pavlov g-pavlov self-assigned this Feb 10, 2021
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Feb 10, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 10, 2021
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 10, 2021
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 10, 2021
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 10, 2021
Copy link
Contributor

@swilen-iwanow swilen-iwanow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@g-pavlov g-pavlov merged commit 11d9b41 into master Feb 11, 2021
@g-pavlov g-pavlov deleted the addurltogitdata branch February 11, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add web URL to host repo in files git info
6 participants