Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence command usage on errors except those that require it for reference #104

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Silence command usage on errors except those that require it for reference #104

merged 1 commit into from
Nov 10, 2020

Conversation

g-pavlov
Copy link
Contributor

@g-pavlov g-pavlov commented Nov 9, 2020 •
edited
Loading

Which issue(s) this PR fixes:
Fixes #103

Release note:

Docforge main command usage is now shown only on flags/cmd/args error.

@g-pavlov g-pavlov added component/documentation Gardener Documentation kind/enhancement Enhancement, improvement, extension labels Nov 9, 2020
@g-pavlov g-pavlov self-assigned this Nov 9, 2020
@gardener-robot gardener-robot added needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Nov 9, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 9, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 9, 2020
@swilen-iwanow
Copy link
Contributor

Thanks! /lgtm

@swilen-iwanow swilen-iwanow added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/review Needs review labels Nov 10, 2020
@gardener-robot gardener-robot added the needs/review Needs review label Nov 10, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 10, 2020
@swilen-iwanow swilen-iwanow force-pushed the master branch 3 times, most recently from 64ad194 to 34ceb8d Compare November 10, 2020 09:28
@swilen-iwanow swilen-iwanow added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 10, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 10, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 10, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 10, 2020
@g-pavlov g-pavlov merged commit 3c46aa6 into master Nov 10, 2020
@g-pavlov g-pavlov deleted the silencecmdusage branch November 10, 2020 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swilen-iwanow swilen-iwanow Awaiting requested review from swilen-iwanow

Assignees

@g-pavlov g-pavlov

Labels
component/documentation Gardener Documentation kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Silence forge command usage on error except wrong flags/cmd/args
5 participants
@g-pavlov @swilen-iwanow @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot