Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Member Management Part2 #872

Merged
merged 34 commits into from
Dec 18, 2020
Merged

Member Management Part2 #872

merged 34 commits into from
Dec 18, 2020

Conversation

grolu
Copy link
Contributor

@grolu grolu commented Nov 6, 2020 •
edited
Loading

What this PR does / why we need it:
Project members are now shown in a table and additional functionality has been implemented.

Screen Shot 2020-12-18 at 11 12 21

Which issue(s) this PR fixes:
Fixes #788

Special notes for your reviewer:

Release note:

Member Management Improvements
- Added feature that allows to rotate secrets of service accounts
- Members are now sortable and shown in table layout
- Added help texts for member roles
- Service Account Members whose Service Account has been deleted, are now flagged in the Dashboard and can be cleaned up

holgerkoser and others added 10 commits October 29, 2020 16:14
@holgerkoser
A few minor fixes and some cosmetic changes to members management
cb8afd6
@holgerkoser
read only projectName from cache
59bb3ce
@holgerkoser
add member description property
8e570c1
@holgerkoser
PR review I
6d5d5d7
@grolu
Added rotate service account secret feature
331cdf5
@grolu
Merge branch 'master' into enh/member-management-4
90685b6 
# Conflicts:
#	backend/lib/services/members/Member.js
#	backend/lib/services/members/MemberManager.js
#	backend/lib/services/members/SubjectList.js
#	backend/lib/services/members/SubjectListItem.js
#	backend/lib/services/members/index.js
#	backend/test/acceptance/api.members.spec.js
@grolu
Merge branch 'master' into enh/member-management-4
5d88cd7
@grolu
Use data table for service account list
e6a7d44
@grolu
use data table for user account list
aab5b4f
@grolu
small fixes
a28323a 
added roles help texts
@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Nov 6, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 6, 2020
@grolu grolu changed the title Enh/member management 4 Member Management Part2 Nov 6, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 6, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 6, 2020
@gardener-robot gardener-robot removed the needs/review Needs review label Nov 11, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 17, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 17, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 17, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 17, 2020
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 17, 2020
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 18, 2020
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 18, 2020
@holgerkoser
Orphaned Robot Members (#914)
f1d8fa2 
* orphaned serviceaccounts

* Simplify extend check
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 18, 2020
holgerkoser
holgerkoser approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging needs/changes Needs (more) changes and removed needs/changes Needs (more) changes needs/second-opinion Needs second review by someone else reviewed/lgtm Has approval for merging labels Dec 18, 2020
holgerkoser
holgerkoser approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging needs/changes Needs (more) changes and removed needs/changes Needs (more) changes reviewed/lgtm Has approval for merging labels Dec 18, 2020
@grolu grolu merged commit 19ce652 into master Dec 18, 2020
@grolu grolu deleted the enh/member-management-4 branch December 18, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petersutter petersutter petersutter approved these changes

@holgerkoser holgerkoser holgerkoser approved these changes

Assignees
No one assigned
Labels
needs/changes Needs (more) changes needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Member Management Improvements
7 participants
@grolu @petersutter @holgerkoser @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot