YAML Editor enhancements #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om Create Cluster Editor
Renamed components
…sible on create cluster page
grolu
added
the
reviewed/do-not-merge
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
added
needs/ok-to-test
grolu
changed the title
grolu
changed the title
# Conflicts: # .secrets.baseline # frontend/src/components/ShootEditor.vue # frontend/src/pages/NewShoot.vue # frontend/src/pages/NewShootEditor.vue # frontend/src/pages/ShootDetailsEditor.vue # frontend/src/store/index.js # frontend/src/store/modules/shoots.js
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
# Conflicts: # backend/package-lock.json # backend/package.json
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
Co-Authored-By: Holger Koser <[email protected]>
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
petersutter
reviewed
Mar 20, 2020
holgerkoser
reviewed
Mar 20, 2020
holgerkoser
reviewed
Mar 20, 2020
holgerkoser
approved these changes
Mar 20, 2020
petersutter
approved these changes
Mar 20, 2020
There was a problem hiding this comment.
apart from the latest comments:
there is still one minor bug for an edge case where the completion fails but we this can be fixed in a separate pr:
ctrl + space to autocomplete a string, press enter and then again, press ctrl + space and enter. The key will change from e.g. test to tetest.
but in general: lgtm
Co-Authored-By: Peter Sutter <[email protected]>
gardener-robot-ci-2
added
reviewed/ok-to-test
Co-Authored-By: Holger Koser <[email protected]>
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
Ok I will look into this |
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
@petersutter can you give feedback if the latest changes resolve your issue? |
|
yes it's solved |
petersutter
reviewed
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Introduces Code Completion and Tooltips in Shoot Editor.
Which issue(s) this PR fixes:
Fixes #36 Fixes #419
Special notes for your reviewer:
Release note: