Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements of Codemirror 6 migration #2190

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Minor improvements of Codemirror 6 migration #2190

merged 4 commits into from
Nov 21, 2024

Conversation

holgerkoser
Copy link
Member

@holgerkoser holgerkoser commented Nov 19, 2024 •
edited by petersutter
Loading

What this PR does / why we need it:
Improvements to CodeMirror 6 migration:

  • Fixed a bug caused by the removal of the refreshEditor method.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Nov 19, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 19, 2024
petersutter
petersutter approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Nov 21, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 21, 2024
grolu
grolu approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@holgerkoser
Merge branch 'master' into enh/codemirror
6942da2 
* master:
  fix: ul must not be a child of p (#2193)
  Fix deprecated Sass `@import` rules (#2186)
  Drop static token kubeconfig support (#2171)
  Bump @eslint/plugin-kit from 0.2.0 to 0.2.3 (#2187)
@holgerkoser
Merge branch 'master' into enh/codemirror
eb6949e 
* master:
  Update dependency @codemirror/view to v6.35.0 (#2194)
  Update vueuse monorepo to v11.3.0 (#2191)
  Bump cross-spawn from 7.0.3 to 7.0.6 (#2189)
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Nov 21, 2024
@holgerkoser holgerkoser merged commit bc0c683 into master Nov 21, 2024
8 checks passed
@holgerkoser holgerkoser deleted the enh/codemirror branch November 21, 2024 13:52
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 21, 2024
@grolu grolu added the area/ipcei IPCEI (Important Project of Common European Interest) label Jan 23, 2025
@grolu grolu mentioned this pull request Jan 23, 2025
Open
64 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grolu grolu grolu approved these changes

@petersutter petersutter petersutter approved these changes

Assignees
No one assigned
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@holgerkoser @petersutter @grolu @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot