Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt to new shoot access restriction configurations in CloudProfile, Seed, and Shoot APIs #2163

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Adapt to new shoot access restriction configurations in CloudProfile, Seed, and Shoot APIs #2163

merged 2 commits into from
Nov 6, 2024

Conversation

petersutter
Copy link
Member

What this PR does / why we need it:
This PR now uses the new fields in CloudProfile, Seed, and Shoot APIs for the shoot access restriction configuration. The new fields were introduced with gardener/gardener#10654.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Access Restrictions:
- This dashboard version requires Gardener version `v1.107.0` if access restrictions are configured.
- The `accessRestriction.items[].display.visibleIf` and `accessRestriction.items[].display.inverted` configurations are no longer supported and will be ignored. The dashboard will now assume `visibleIf=true` and `inverted=false`. However, this change does not affect the `accessRestriction.items[].input.options[].display.visibleIf` and `accessRestriction.items[].input.options[].display.inverted` settings.

@gardener-robot gardener-robot added needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Nov 4, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 4, 2024
@petersutter petersutter mentioned this pull request Oct 18, 2024
Closed
3 tasks
holgerkoser
holgerkoser approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Nov 6, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 6, 2024
@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Nov 6, 2024
@gardener-robot
Copy link

@petersutter You need rebase this pull request with latest master branch. Please check.

@gardener-robot gardener-robot removed the reviewed/lgtm Has approval for merging label Nov 6, 2024
@gardener-robot gardener-robot added the needs/second-opinion Needs second review by someone else label Nov 6, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Nov 6, 2024
@petersutter petersutter merged commit 218d7ea into master Nov 6, 2024
8 checks passed
@petersutter petersutter deleted the access-restrictions branch November 6, 2024 11:47
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 6, 2024
holgerkoser added a commit that referenced this pull request Nov 13, 2024
@holgerkoser
Merge branch 'master' into openmfp
884ed92 
* master: (140 commits)
  Update dependency @codemirror/autocomplete to v6.18.3 (#2175)
  Update dependency uuid to v11.0.3 (#2173)
  Drop usage of deprecated credential.secretRef (#2169)
  Move GShootListRowActions from GShootListRow to GShootList component (#2148)
  Adapt to new shoot access restriction configurations in `CloudProfile`, `Seed`, and `Shoot` APIs (#2163)
  Upgrade to eslint v9 and move to neostandard (#2137)
  Update dependency vuetify to v3.7.4 (#2168)
  Update dependency @octokit/auth-app to v6.1.3 (#2167)
  Update Monthly Dev Dependencies (#2160)
  Update vueuse monorepo to v11.2.0 (#2158)
  Remove fallback to read cluster ca Secret (#2164)
  Update dependency @codemirror/view to v6.34.2 (#2165)
  Update dependency pinia to v2.2.6 (#2162)
  Update dependency @codemirror/search to v6.5.7 (#2161)
  Update dependency compression to v1.7.5 (#2159)
  Update dependency @codemirror/autocomplete to v6.18.2 (#2157)
  Update dependency universal-cookie to v7.2.2 (#2156)
  Update dependency pinia to v2.2.5 (#2154)
  Update dependency uuid to v11 (#2151)
  Update dependency @kyvg/vue3-notification to v3.4.1 (#2153)
  ...

# Conflicts:
#	.pnp.cjs
#	backend/lib/app.js
#	backend/lib/config/gardener.js
#	backend/lib/security/index.js
#	backend/lib/services/projects.js
#	backend/lib/services/shoots.js
#	backend/package.json
#	frontend/package.json
#	frontend/src/components/dialogs/GProjectDialog.vue
#	frontend/src/composables/useProjectContext.js
#	frontend/src/store/app.js
#	frontend/src/views/GAdministration.vue
#	frontend/src/views/GShootList.vue
#	yarn.lock
@grolu grolu added the area/ipcei IPCEI (Important Project of Common European Interest) label Jan 23, 2025
@grolu grolu mentioned this pull request Jan 23, 2025
Open
64 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerkoser holgerkoser holgerkoser approved these changes

@grolu grolu Awaiting requested review from grolu grolu is a code owner

Assignees
No one assigned
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/rebase Needs git rebase needs/second-opinion Needs second review by someone else size/l Size of pull request is large (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@petersutter @gardener-robot @holgerkoser @gardener-robot-ci-1 @grolu @gardener-robot-ci-3