Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Project Services and Routes #1946

Merged
merged 10 commits into from
Jul 18, 2024
Merged

Refactor Project Services and Routes #1946

merged 10 commits into from
Jul 18, 2024

Conversation

petersutter
Copy link
Member

What this PR does / why we need it:
This PR includes several changes aimed at improving the project services and routes within the application. The key changes are:

  • Renamed the legacy project service to namespace.
  • Added a new route for projects and removed the old from/to mapping.
  • Updated the application to use the new projects route and removed the redundant from/to mapping code.
  • Improved the handling of project deletions.
  • Extracted cost-related logic into a separate composable object.
  • Made minor improvements to the codebase.

Which issue(s) this PR fixes:
Fixes #1631

Special notes for your reviewer:

Release note:

@gardener-robot gardener-robot added the needs/review Needs review label Jul 1, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 1, 2024
@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jul 1, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 1, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 1, 2024
@petersutter petersutter force-pushed the enh/project-improvements branch from 1423987 to 9bd2d22 Compare July 2, 2024 12:24
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 2, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 2, 2024
@petersutter petersutter force-pushed the enh/project-improvements branch from 9bd2d22 to fc1b61f Compare July 2, 2024 13:21
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 2, 2024
holgerkoser
holgerkoser reviewed Jul 15, 2024
View reviewed changes
frontend/src/views/GAdministration.vue Show resolved Hide resolved
backend/lib/routes/index.js Outdated Show resolved Hide resolved
frontend/src/views/GMembers.vue Outdated Show resolved Hide resolved
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 15, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 15, 2024
grolu
grolu approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@grolu grolu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Jul 15, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 15, 2024
holgerkoser
holgerkoser approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Jul 15, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 15, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 16, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 16, 2024
@grolu grolu added the area/ipcei IPCEI (Important Project of Common European Interest) label Jul 17, 2024
@grolu grolu mentioned this pull request Jul 17, 2024
Open
64 tasks
@petersutter petersutter merged commit f85457c into master Jul 18, 2024
8 checks passed
@petersutter petersutter deleted the enh/project-improvements branch July 18, 2024 13:58
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 18, 2024
holgerkoser added a commit that referenced this pull request Jul 25, 2024
@holgerkoser
Merge branch 'master' into openmfp
5c2cc4d 
* master: (32 commits)
  Fixed broken links + updated markdown (#1998)
  Fixes some problems with latest dependency updates (#2000)
  Cleanup GShootStatus component (#1983)
  Update dependency eslint-plugin-promise to v7 (#2002)
  Fixed worker group zone configuration for existing azure clusters (#1999)
  Update dependency @vitejs/plugin-vue to v5.1.0 (#2001)
  Add YAML line selection highlighting in GShootEditor (#1982)
  Update dependency universal-cookie to v7.2.0 (#1997)
  Update dependency codemirror to v5.65.17 (#1995)
  Update dependency eslint-plugin-promise to v6.6.0 (#1994)
  Update dependency vuetify to v3.6.13 (#1984)
  Update dependency vitest-fetch-mock to ^0.3.0 (#1973)
  Update dependency semver to v7.6.3 (#1985)
  Update dependency jsdom to v24.1.1 (#1996)
  Update dependency dayjs to v1.11.12 (#1990)
  Update dependency vue to v3.4.33 (#1993)
  Update dependency vue to v3.4.32 (#1986)
  Refactor Project Services and Routes (#1946)
  Dockerfile: fix LegacyKeyValueFormat warning (#1980)
  Update dependency path-to-regexp to v7.1.0 (#1979)
  ...

# Conflicts:
#	.pnp.cjs
#	.yarn/cache/@babel-types-npm-7.24.9-5c021bc930-4970b3481c.zip
#	.yarn/cache/@vue-compiler-core-npm-3.4.33-60a5f78a6b-5f3e97b9bf.zip
#	.yarn/cache/@vue-compiler-dom-npm-3.4.33-c65b16ab1e-78b92901c1.zip
#	.yarn/cache/@vue-compiler-ssr-npm-3.4.33-bc74b83c94-cbab397abc.zip
#	.yarn/cache/@vue-server-renderer-npm-3.4.33-0e097c06b7-24b3b57bdb.zip
#	.yarn/cache/@vue-shared-npm-3.4.33-28b977b008-010603f80b.zip
#	.yarn/cache/acorn-walk-npm-8.3.3-868c75184d-4a9e24313e.zip
#	.yarn/cache/deep-eql-npm-4.1.3-020a64f862-ff34e8605d.zip
#	.yarn/cache/deep-eql-npm-4.1.4-bc4d39c2ca-264e061349.zip
#	.yarn/cache/deep-eql-npm-5.0.2-3bce58289f-7102cf3b7b.zip
#	.yarn/cache/electron-to-chromium-npm-1.4.812-4e84ce97b2-d5cff49155.zip
#	.yarn/cache/es-abstract-npm-1.23.3-ffd85665f7-d27e9afafb.zip
#	.yarn/cache/https-proxy-agent-npm-7.0.5-94c14d4619-2490e3acec.zip
#	.yarn/cache/is-core-module-npm-2.14.0-24e925b9e1-ae8dbc82bd.zip
#	.yarn/cache/js-tokens-npm-9.0.0-35a2868eaf-4ad1c12f47.zip
#	.yarn/cache/mlly-npm-1.7.1-c00aa0548e-d836a7b0ad.zip
#	.yarn/cache/object-inspect-npm-1.13.2-3c6e11a536-b97835b4c9.zip
#	.yarn/cache/strip-literal-npm-2.1.0-3503c34c5f-bc8b8c8346.zip
#	.yarn/cache/tinypool-npm-0.8.3-546e741566-c219d0cfb6.zip
#	.yarn/cache/tinypool-npm-0.8.4-043dfecb16-779c790adc.zip
#	.yarn/cache/tinypool-npm-1.0.0-01bf44ef1d-71b20b9c54.zip
#	.yarn/cache/tinyspy-npm-2.2.1-1079b8de54-0b4cfd07c0.zip
#	.yarn/cache/typed-array-length-npm-1.0.6-867a36a1ac-74253d7dc4.zip
#	.yarn/cache/ufo-npm-1.5.3-8c9d710312-1df1070258.zip
#	.yarn/cache/ws-npm-8.17.0-05fb441faf-55241ec93a.zip
#	.yarn/cache/ws-npm-8.17.1-f57fb24a2c-f4a49064af.zip
#	.yarn/cache/ws-npm-8.18.0-56f68bc4d6-25eb33aff1.zip
#	backend/lib/services/projects.js
#	frontend/src/components/dialogs/GProjectDialog.vue
#	yarn.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerkoser holgerkoser holgerkoser approved these changes

@grolu grolu grolu approved these changes

Assignees
No one assigned
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/second-opinion Needs second review by someone else size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong namespace set in garden cluster kubeconfig on MY ACCOUNT page
7 participants
@petersutter @holgerkoser @grolu @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot