Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix-1.74] Do not fail if tickets could not be fetched #1905

Merged
merged 1 commit into from
Jun 7, 2024
Merged

[hotfix-1.74] Do not fail if tickets could not be fetched #1905

merged 1 commit into from
Jun 7, 2024

Conversation

petersutter
Copy link
Member

What this PR does / why we need it:

  • Do not fail if tickets could not be fetched
  • fix margins when displaying multiple tickets

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fixed an issue where the shoot details page could not be loaded when GitHub comments could not be fetched

@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jun 7, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 7, 2024
holgerkoser
holgerkoser approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Jun 7, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 7, 2024
@petersutter petersutter merged commit 56c95e6 into hotfix-1.74 Jun 7, 2024
6 checks passed
@petersutter petersutter deleted the bug/hotfix1.74-1876 branch June 7, 2024 14:56
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerkoser holgerkoser holgerkoser approved these changes

@grolu grolu Awaiting requested review from grolu

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petersutter @holgerkoser @gardener-robot-ci-2 @gardener-robot