Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure extension DNS settings in the spec.extensions section #1888

Merged
merged 24 commits into from
Jul 8, 2024
Merged

Configure extension DNS settings in the spec.extensions section #1888

merged 24 commits into from
Jul 8, 2024

Conversation

grolu
Copy link
Contributor

@grolu grolu commented May 28, 2024 •
edited by petersutter
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #1723

Special notes for your reviewer:

Release note:

Enhanced DNS configuration logic to configure extension DNS settings in the `spec.extensions` section
DNS configuration is now maintained under `spec.extensions`. When modifying the DNS configuration of an existing shoot, the settings will be migrated to this new location, and the `syncProvidersFromShootSpecDNS` flag will be set to false

@gardener-robot gardener-robot added needs/review Needs review size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels May 28, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 28, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 28, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 28, 2024
@grolu grolu changed the title Maintain DNS extension providers under spec.extensions Configure extension DNS settings in the spec.extensions section May 28, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 29, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 29, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 3, 2024
@grolu grolu force-pushed the enh/adapt_to_dns_changes branch from 141ae50 to 5b26d8b Compare June 4, 2024 13:01
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 4, 2024
@grolu grolu added the area/ipcei IPCEI (Important Project of Common European Interest) label Jun 4, 2024
@grolu grolu mentioned this pull request Jun 4, 2024
Open
64 tasks
petersutter
petersutter reviewed Jun 4, 2024
View reviewed changes
backend/lib/services/shoots.js Outdated Show resolved Hide resolved
backend/lib/services/shoots.js Outdated Show resolved Hide resolved
backend/lib/services/shoots.js Outdated Show resolved Hide resolved
frontend/src/components/ShootDns/GDnsConfiguration.vue Outdated Show resolved Hide resolved
frontend/src/components/ShootDns/GManageDns.vue Outdated Show resolved Hide resolved
frontend/src/composables/useShootContext/index.js Outdated Show resolved Hide resolved
frontend/src/composables/useShootSpec.js Outdated Show resolved Hide resolved
frontend/src/composables/useShootSpec.js Outdated Show resolved Hide resolved
frontend/src/composables/useShootSpec.js Outdated Show resolved Hide resolved
frontend/src/sass/main.scss Show resolved Hide resolved
holgerkoser
holgerkoser reviewed Jun 6, 2024
View reviewed changes
backend/__fixtures__/shoots.js Outdated Show resolved Hide resolved
backend/lib/services/shoots.js Outdated Show resolved Hide resolved
frontend/src/store/gardenerExtension.js Outdated Show resolved Hide resolved
frontend/src/composables/useShootSpec.js Outdated Show resolved Hide resolved
frontend/src/composables/useShootSpec.js Show resolved Hide resolved
frontend/src/components/ShootDns/GManageDns.vue Outdated Show resolved Hide resolved
frontend/src/components/ShootDns/GManageDns.vue Outdated Show resolved Hide resolved
frontend/src/components/ShootDns/GManageDns.vue Outdated Show resolved Hide resolved
frontend/src/composables/useShootContext/index.js Outdated Show resolved Hide resolved
frontend/src/composables/useShootContext/index.js Outdated Show resolved Hide resolved
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 7, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 7, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 10, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jun 26, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 28, 2024
@grolu
Reset domain input field
dc7e3a4 
Apply alert optimizations
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jun 28, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 8, 2024
holgerkoser
holgerkoser reviewed Jul 8, 2024
View reviewed changes
frontend/__tests__/composables/useShootDns.spec.js Outdated Show resolved Hide resolved
frontend/__tests__/composables/useShootDns.spec.js Outdated Show resolved Hide resolved
frontend/__tests__/composables/useShootDns.spec.js Outdated Show resolved Hide resolved
frontend/__tests__/composables/useShootDns.spec.js Outdated Show resolved Hide resolved
frontend/src/components/Secrets/GSecretDialogWrapper.vue Outdated Show resolved Hide resolved
frontend/src/components/Secrets/GSelectSecret.vue Outdated Show resolved Hide resolved
frontend/src/components/ShootDns/GDnsProviderRow.vue Outdated Show resolved Hide resolved
frontend/src/components/ShootDns/GDnsProviderRow.vue Outdated Show resolved Hide resolved
frontend/src/components/ShootDns/GDnsProviderRow.vue Outdated Show resolved Hide resolved
frontend/src/components/ShootDns/GManageDns.vue Outdated Show resolved Hide resolved
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 8, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 8, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 8, 2024
petersutter
petersutter approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/rebase Needs git rebase needs/review Needs review needs/second-opinion Needs second review by someone else labels Jul 8, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 8, 2024
holgerkoser
holgerkoser approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@holgerkoser holgerkoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@grolu grolu merged commit 4af534a into master Jul 8, 2024
8 checks passed
@grolu grolu deleted the enh/adapt_to_dns_changes branch July 8, 2024 15:47
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerkoser holgerkoser holgerkoser approved these changes

@petersutter petersutter petersutter approved these changes

Assignees
No one assigned
Labels
area/ipcei IPCEI (Important Project of Common European Interest) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adapt handling of DNS Providers
7 participants
@grolu @gardener-robot @holgerkoser @petersutter @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3