Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix-1.61] Bug/fix dns provider list hotfix #1323

Merged
merged 1 commit into from
Oct 18, 2022
Merged

[hotfix-1.61] Bug/fix dns provider list hotfix #1323

merged 1 commit into from
Oct 18, 2022

Conversation

grolu
Copy link
Contributor

@grolu grolu commented Oct 18, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fixed: Empty DNSProvider list for Gardener versions > 1.54.0

This Dashboard version is not compatible with Gardener versions prior `v1.54.x`

@grolu
Adapted DNS Provider List getters to work with latest Gardener Releas…
806c180 
…es (#1320)

* Adapted DNS Provider List getters to work with latest Gardener Releases

* PR Feedback
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Oct 18, 2022
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 18, 2022
petersutter
petersutter approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@petersutter petersutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 18, 2022
@grolu grolu merged commit 97b1239 into hotfix-1.61 Oct 18, 2022
@grolu grolu deleted the bug/fix_dns_provider_list_hotfix branch October 18, 2022 18:14
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petersutter petersutter petersutter approved these changes

@holgerkoser holgerkoser Awaiting requested review from holgerkoser

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grolu @petersutter @gardener-robot-ci-3 @gardener-robot