feat: Introduce certificate duration #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-prow
bot
added
kind/enhancement
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-prow
bot
added
the
needs-rebase
MartinWeindel
requested changes
Nov 12, 2024
There was a problem hiding this comment.
I have some doubts about unsafe usage of *time.Duration in some helper methods.
If I remember correctly, the Duration field of the struct ObtainInput is a pointer, as it may be unset for the ACME case. But at some level there should be a check to guard against nil pointer exception.
cherry picked from: 32bd917
marc1404
force-pushed
the
feat/certificate-duration
branch
from
a5db567 to
46e7aaa
Compare
gardener-prow
bot
removed
the
needs-rebase
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot-ci-2
added
reviewed/ok-to-test
|
LGTM label has been added. Git tree hash: 8430d60057b25891ecb12756c1763d155a16d579
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MartinWeindel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
gardener-prow
bot
added
the
approved
gardener-robot-ci-2
added
the
reviewed/ok-to-test
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
This PR cherry-picks commits from #228 and introduces the
Durationfield on theCertificateresource.It allows you to specify the certificate's lifetime. Issuers, like Let's Encrypt, may ignore this field.
As a secondary goal, by extracting the changes around the duration of certificates from #228 its changeset should become smaller and focused around the introduction of the self-signed issuer.
Which issue(s) this PR fixes:
n.a.
Special notes for your reviewer:
/cc @MartinWeindel
Release note: