Istio and Gateway API gateway resources as source objects #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot
added
size/XL
gardener-robot-ci-3
added
needs/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
MartinWeindel
added
the
area/ipcei
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The Istio resource
Gatewaycan now be annotated withcert.gardener.cloud/purpose=managedto enable the automatic creation ofCertificateresources for domain names extracted from hosts fields in this resource or relatedVirtualServicesresources.The
GatewayandHTTPRouteresources from the Gateway API are supported in a similar way.As the custom resource definitions for Istio or the Gateway API are optionally, these resources are only watched if they are available. As a side-effect, if these custom resources are added or removed, the cert-controller-manager container exits to restart and reconfigure its controller to the new situation.
Which issue(s) this PR fixes:
Fixes #29
Special notes for your reviewer:
Related to same feature for dns-controller-managaer, see to gardener/external-dns-management#354
Release note: