Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Improve the repository context handling in the resolver #38

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Improve the repository context handling in the resolver #38

merged 1 commit into from
Jun 2, 2021

Conversation

schrodit
Copy link

@schrodit schrodit commented Jun 2, 2021

What this PR does / why we need it:

Improve the repository context handling in the resolver so that the repository context in the descriptor is only treated as information.
We do not rely on that field anymore.
also added:

  • a optional cache for the oci resolver
  • a util function to traverse all component references
  • unit tests for the resolver and the cache

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

[GO Binding]
The component descriptors `RepositoryContext` is now only for information purposes.
All tooling should not rely on that fields anymore. The provided user repository context should be used instead.

[GO Binding]
The `ctf.ComponentResolver` has been adjusted so that the BlobResolver can now be optionally returned.
The included oci resolver has been adjusted accordingly and does now implement the `ctf.ComponentResolver` interface

[GO Binding]
A optional cache has been added to the oci resolver.

Improve the repository context handling in the resolver
6c0265d 
also added:
- a optional cache for the oci resolver
- a util function to traverse all component references
- unit tests for the resolver and the cache
@gardener-robot gardener-robot added needs/review Needs review size/l Size of pull request is large (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Jun 2, 2021
@schrodit
Copy link
Author

schrodit commented Jun 2, 2021

/invite @enrico-kaack-comp @jschicktanz

@schrodit schrodit merged commit 3b8cc75 into gardener-attic:master Jun 2, 2021
@schrodit schrodit deleted the impr-ctx-handling branch June 2, 2021 12:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@enrico-kaack-comp enrico-kaack-comp enrico-kaack-comp approved these changes

@jschicktanz jschicktanz jschicktanz approved these changes

Assignees
No one assigned
Labels
needs/review Needs review needs/second-opinion Needs second review by someone else size/l Size of pull request is large (see gardener-robot robot/bots/size.py)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@schrodit @jschicktanz @enrico-kaack-comp @gardener-robot