Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not autoswing fishing poles #3

Closed
wants to merge 1 commit into from
Closed

Do not autoswing fishing poles #3

wants to merge 1 commit into from

Conversation

slippycheeze
Copy link

No description provided.

@gardenappl
Copy link
Owner

I'm really sorry for not replying for so long.

Have you tested this? You put the fishingPole check after the projectile check, and fishing poles do actually throw projectiles. I'll try your fix, and if it doesn't work, I'll put this check at the start of the method.

@gardenappl
Copy link
Owner

gardenappl commented Jul 14, 2017

After some testing, I figured out that changing the item.damage == 0 check to item.damage <= 0 actually fixes fishing poles (since by default, non-weapons have damage set to -1). I'm not sure if that breaks anything, but this is probably a better way to do it.

gardenappl added a commit that referenced this pull request Jul 14, 2017
@slippycheeze
Copy link
Author

Thanks for fixing this. I didn't actually test it, so it probably was wrong, but at least it clearly communicated what sort of change was desired. Thanks for the mod, by the way!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants