improvement(k8s): cluster cleanup command now also cleans build sync dir #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eysi09
requested changes
Jul 14, 2019
|
|
||
| // Filter to directories last accessed more than workspaceSyncDirTtl ago | ||
| const minTimestamp = new Date().getTime() / 1000 - workspaceSyncDirTtl | ||
| console.log(minTimestamp) |
| log.setSuccess() | ||
| } | ||
|
|
||
| async function getBuildSyncPodName(provider: KubernetesProvider, log: LogEntry) { |
There was a problem hiding this comment.
Could you add a comment saying that this returns the name of the first build-sync pod found and that there are usually some replicas.
edvald
force-pushed
the
build-sync-cleanup
branch
from
2c67ff1 to
69f4198
Compare
|
Comments addressed |
eysi09
approved these changes
Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Previously, workspace directories that we synced to the cluster for in-cluster building would just pile up. Now they are cleaned up when you run
garden plugins kubernetes cleanup-cluster-registry