Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: declare latest version of fsevents explicity #955

Merged
merged 1 commit into from
Jul 11, 2019

Conversation

10ko
Copy link
Member

@10ko 10ko commented Jul 11, 2019

What type of PR is this?

fix

What this PR does / why we need it:
When running npm install with the latest version of node, fsevents library would throw errors.
The current version of chokidar we use requires some libraries, which require a very old version of the library. This PR brings requires the latest version of fsevents explicitly so we satisfy the dependency and fix the error (see #947).

Which issue(s) this PR fixes:

Fixes #947

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
Nope

@10ko 10ko requested review from edvald, thsig and eysi09 July 11, 2019 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: Upgrade dashboard dependecies to support latest version of node
2 participants