Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: consistent punctuation in command descriptions #919

Merged
merged 3 commits into from
Jul 8, 2019
Merged

style: consistent punctuation in command descriptions #919

merged 3 commits into from
Jul 8, 2019

Conversation

baspetersdotjpeg
Copy link
Contributor

Ordnung muss sein!

@baspetersdotjpeg baspetersdotjpeg force-pushed the cli-punctuation-fixes branch from b634c7b to aa18373 Compare July 5, 2019 09:19
edvald
edvald approved these changes Jul 5, 2019
View reviewed changes
Copy link
Collaborator

@edvald edvald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but you need to run npm run generate-docs and commit the updated files for the tests to pass.

@baspetersdotjpeg
Copy link
Contributor Author

@edvald done.

@edvald edvald merged commit 8ca0813 into master Jul 8, 2019
@edvald edvald deleted the cli-punctuation-fixes branch July 8, 2019 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edvald edvald edvald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@baspetersdotjpeg @edvald