improvement(k8s): more robust and useful deployment status checks #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edvald
force-pushed
the
status-improvements
branch
from
b85b43d to
adfec32
Compare
edvald
force-pushed
the
status-improvements
branch
2 times, most recently
from
3161158 to
89a0e24
Compare
thsig
approved these changes
Jun 24, 2019
This combines a general refactor of our workload status checks, more robust checking of related resource statuses (in order to fail fast on common errors like ImagePullBackOff and CrashLoopBackOff), as well as an improvement on the level of information given when errors do come up. This should aid considerably in debugging deployment issues. Closes #863
thsig
force-pushed
the
status-improvements
branch
from
89a0e24 to
4f1ff3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This combines a general refactor of our workload status checks, more
robust checking of related resource statuses (in order to fail fast on
common errors like ImagePullBackOff and CrashLoopBackOff), as well as an
improvement on the level of information given when errors do come up.
This should aid considerably in debugging deployment issues.
Closes #863
To test, I recommend breaking modules in any way you can think of, For example, make the command/args invalid such that the container doesn't start, have the container crash right after start, specify an invalid image (to trigger ImagePullBackOff) etc.