Init flow improvement #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thsig
approved these changes
Jun 10, 2019
garden-service/src/actions.ts
Outdated
| const entry = log.info({ section: "providers", msg: "Getting status...", status: "active" }) | ||
| const statuses = await this.getEnvironmentStatus({ pluginName, log: entry }) | ||
|
|
||
| const needManualInit = Object.entries(statuses) | ||
| .map(([name, status]) => ({ ...status, name })) | ||
| .filter(status => status.ready === false && status.needManualInit === true) | ||
|
|
||
| if (!allowUserInput && needManualInit.length > 0) { | ||
| if (!init && needManualInit.length > 0) { |
There was a problem hiding this comment.
Just a thought—would manualInit be a clearer name than init here? Or alternatively, using needInit instead of needManualInit? If I'm, not mistaken, they're both referring to the same flag.
| force: Joi.boolean() | ||
| .description("Force re-configuration of the environment."), | ||
| init: Joi.boolean() | ||
| .description("Set to true if the environment is being explicitly initialized via `garden init`"), |
This signals to the handler whether it's being run implicitly, or explicitly in the context of `garden init`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.