fix(templates): fix regression with multiple if statements introduced in 0.13.46 #6714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.13.45 In `buildConditionalTree`, we did not properly reset state and thus we got a wrong AST if multiple if statements existed in the same nesting level.
stefreak
force-pushed
the
fix-multiple-if
branch
from
4111940 to
88b242a
Compare
vvagaytsev
approved these changes
Dec 12, 2024
stefreak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In
buildConditionalTree, we did not properly reset state and thus wegot a wrong AST if multiple if statements existed in the same nesting
level.
Which issue(s) this PR fixes:
Fixes #6711
Special notes for your reviewer: