fix(local-k8s): ensure correct nginx status when getting env status #6696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use the `clusterType` config field to determine the status of the nginx ingress controller when applicable for the `local-kubernetes` provider. Before this fix however, we'd set the `clusterType` on the provider config (if needed) in the `prepareEnvironment` handler and not the `getEnvironmentStatus` handler. This basically resulted in the `getEnvironmentStatus` handler always returning that nginx wasn't ready, then the `clusterType` would be set in the `prepareEnvironment` and the status checked again, this time correctly.
vvagaytsev
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We use the
clusterTypeconfig field to determine the status of the nginx ingress controller when applicable for thelocal-kubernetesprovider.Before this fix however, we'd set the
clusterTypeon the provider config (if needed) in theprepareEnvironmenthandler and not thegetEnvironmentStatushandler.This basically resulted in the
getEnvironmentStatushandler always returning that nginx wasn't ready, then theclusterTypewould be set in theprepareEnvironmentand the status checked again, this time correctly.Now we "correctly" set the
clusterTypein thegetEnvironmentStatus(arguably it should be set in theconfigureProviderhandler but that would be a bigger refactor and I believe this is a pattern we use in other places as well).Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: