perf: optimise template string resolving performance #6685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We optimise the template string resolving performance by making sure that we only parse each template expression once. Once parsed, we use the AST to evaluate template expressions.
stefreak
commented
Dec 2, 2024
Co-authored-by: Vladimir Vagaytsev <[email protected]>
stefreak
commented
Dec 3, 2024
stefreak
commented
Dec 3, 2024
Co-authored-by: Vladimir Vagaytsev <[email protected]>
ScanContext does not work with AST, because it does not eagerly resolve all variables anymore. we have to walk the AST intead.
…in action references
Co-authored-by: Steffen Neubauer <[email protected]>
stefreak
force-pushed
the
template-string-perf
branch
from
0a6afb7 to
3397b0e
Compare
stefreak
force-pushed
the
template-string-perf
branch
from
620ecc5 to
3a71187
Compare
10ko
approved these changes
Dec 6, 2024
edvald
reviewed
Dec 6, 2024
| @@ -1,5 +1,5 @@ | |||
| require: | |||
| - build/test/setup.js | |||
| - ../../../../build/test/setup.js | |||
There was a problem hiding this comment.
Seems a little odd - What prompted this change?
There was a problem hiding this comment.
Vovas IDE needed it to be able to run tests, and it didn't seem to have an effect on CI
There was a problem hiding this comment.
But I agree it's odd, will have a closer look at this
eysi09
reviewed
Dec 6, 2024
stefreak
added a commit
that referenced
this pull request
Dec 9, 2024
operators (`!` and `typeof`). Older versions of garden did not throw an error when referencing missing variables from unary operators like `!` and `typeof`. This commit restores backwards-compatiblity that has been broken in #6685
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
…ary operators (`!` and `typeof`). (#6695) fix: retain bug-compatibility for referencing missing variables in unary operators (`!` and `typeof`). Older versions of garden did not throw an error when referencing missing variables from unary operators like `!` and `typeof`. This commit restores backwards-compatiblity that has been broken in #6685
vvagaytsev
reviewed
Dec 10, 2024
vvagaytsev
added a commit
that referenced
this pull request
Dec 10, 2024
A follow-up for #6685. Replays #6408 on top of #6685. Co-authored-by: Steffen Neubauer <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
A follow-up for #6685. Replays #6408 on top of #6685. Co-authored-by: Steffen Neubauer <[email protected]>
stefreak
added a commit
that referenced
this pull request
Dec 12, 2024
…anifest files Template strings in Kubernetes manifest files are partially resolved for legacy reasons. The partial resolve behaviour has been changed to improve sanity in #6685 but for kubernetes manifest files, we need to have a version of the old behaviour. The expected legacy behaviour looks like this: - If template strings reference variables that do not exist there is no error - If a template string contains multiple template expressions, each expression can be partially resolved. - Template expressions are evaluated before parsing yaml, which means that valid yaml with template expressions can be resolved to invalid yaml (e.g. if variable values contain special characters) This legacy behaviour can lead to quite some surprises and UX problems, for example #5266 I would suggest that we remove this functionality in 0.14.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
…anifest files (#6713) * fix(template): establish backwards bug-compatibility for kubernetes manifest files Template strings in Kubernetes manifest files are partially resolved for legacy reasons. The partial resolve behaviour has been changed to improve sanity in #6685 but for kubernetes manifest files, we need to have a version of the old behaviour. The expected legacy behaviour looks like this: - If template strings reference variables that do not exist there is no error - If a template string contains multiple template expressions, each expression can be partially resolved. - Template expressions are evaluated before parsing yaml, which means that valid yaml with template expressions can be resolved to invalid yaml (e.g. if variable values contain special characters) This legacy behaviour can lead to quite some surprises and UX problems, for example #5266 I would suggest that we remove this functionality in 0.14. * test: fix running tests on macos this commit fixes the "cannot find dockerfile" error that plagued us on macos * test: add integ tests for legacyAllowPartial behaviour in kubernetes manifests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We optimise the template string resolving performance by
making sure that we only parse each template expression once. Once
parsed, we use the AST to evaluate template expressions.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Changes are inspired from #5496