Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: get rid of fs.Stats constructor deprecation warning #6653

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

vvagaytsev
Copy link
Collaborator

@vvagaytsev vvagaytsev commented Nov 19, 2024

What this PR does / why we need it:

Remove unnecessary child-class and use type intersection with factory method instead.

Which issue(s) this PR fixes:

Fixes compilation errors in #6622.

Special notes for your reviewer:

Remove unnecessary child-class and use type intersection with factory method instead.
@vvagaytsev vvagaytsev force-pushed the refactor/get-rid-of-fs-stats-extension branch from c353109 to dd8734e Compare November 19, 2024 09:51
@vvagaytsev vvagaytsev marked this pull request as ready for review November 19, 2024 10:10
@vvagaytsev vvagaytsev enabled auto-merge November 19, 2024 10:12
Copy link
Member

@stefreak stefreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

The build staging code is very complex, great to get rid of that deprecation warning.

@vvagaytsev vvagaytsev added this pull request to the merge queue Nov 19, 2024
Merged via the queue into main with commit 31c72a1 Nov 19, 2024
40 checks passed
@vvagaytsev vvagaytsev deleted the refactor/get-rid-of-fs-stats-extension branch November 19, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants