chore: logging corrections and tweaks #6553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To see the exact exec time in the log files.
thsig
requested changes
Oct 16, 2024
@thsig let's do that later. Now we need those log at the debug level to be able to see the timestamps of each operation in the log files. We do not log silly-level logs on disk, so we can't see timestamps. |
thsig
approved these changes
Oct 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 16, 2024
* chore: more precise log message on bad action name * chore: log action batches on debug-level To see the exact exec time in the log files. * chore: extra logging in the slow function
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
vvagaytsev
added a commit
that referenced
this pull request
Oct 18, 2024
Revert some changes from #6553
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
* chore: remove excessive logging Revert some changes from #6553 * chore: log action preprocessing and ver merging durations * chore: print fine-grained messages on silly level * chore: remove outdated todo-comment * chore: log action pre-/processing batch exec time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: