-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(git): use sub-tree
scan mode for config files scan
#6483
Conversation
The big question for me here is: what are the benchmark results? is it faster, slower, same performance? |
To evaluate that we need to look at various cases, even different commands etc. I can't quite imagine how this would turn out to be slower outside of very rare cases and even then marginally, but I don't object to running a few performance tests to see how it shakes out. |
@stefreak sure, sorry, I accidentally created it before I completed the description. With With I think that's because repo does process more files than We can keep both changes:
|
No need to overdo it @vvagaytsev :) Just good to see a couple of different variations. |
I agree, if y'all think this is definitely an improvement I'm all for it, I just don't understand the vcs code to be honest so that's why I wanted to see proof that this is better than before :) |
Just tested this against main branch with 100k files project (used https://github.com/garden-io/garden-large-repo-generator to generate that). All files were tracked. This PR did the initial scan in 0.2-0.3 sec against 0.5-0.6 sec in main. So, it looks it's ready to go. |
What this PR does / why we need it:
This idea was discussed in #6461.
Use
sub-tree
scan mode for config files scanning. NowGarden
has the second VCS handler - a dedicatedSubTreeGitHandler
that only performs config files scan. Both VCS handlers share the sameTreeCache
.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: