Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement(k8s): better deployment status checking #643

Merged
merged 1 commit into from
Mar 22, 2019
Merged

improvement(k8s): better deployment status checking #643

merged 1 commit into from
Mar 22, 2019
+225 −52

Conversation

edvald
Copy link
Collaborator

@edvald edvald commented Mar 18, 2019

No description provided.

@thsig
Copy link
Collaborator

thsig commented Mar 19, 2019

If I run garden deploy and then garden get status in the hello-world project, I get the following error:

events.js:183
      throw er; // Unhandled 'error' event
      ^

Error: write EPIPE
    at _errnoException (util.js:1022:11)
    at WriteWrap.afterWrite [as oncomplete] (net.js:880:14)```

@edvald edvald force-pushed the k8s-status-check-improvement branch from 45e640b to 4c57621 Compare March 19, 2019 11:06
@edvald
Copy link
Collaborator Author

edvald commented Mar 19, 2019

I've fixed the above issue. Was an elusive one—apparently Node dislikes it when a process exits while you're still writing to stdin.

@thsig thsig force-pushed the k8s-status-check-improvement branch from 4c57621 to d84c97e Compare March 22, 2019 13:25
@thsig thsig merged commit 8be1961 into master Mar 22, 2019
@thsig thsig deleted the k8s-status-check-improvement branch March 22, 2019 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thsig thsig thsig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edvald @thsig