fix: add applyArgs to kubectl apply function #6385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for you PR, @ManAnRuck! 👍 💯 The changes look good! The tests for Kubernetes deploy action handlers can be found in You can pass some Please let us know if you need any assistance. |
ManAnRuck
force-pushed
the
applyArgs
branch
9 times, most recently
from
c0803ab to
fadd230
Compare
vvagaytsev
previously approved these changes
Sep 3, 2024
added 2 commits
September 3, 2024 14:30
Signed-off-by: Manuel Ruck <[email protected]>
Signed-off-by: Manuel Ruck <[email protected]>
vvagaytsev
force-pushed
the
applyArgs
branch
from
263ce22 to
0f95f2b
Compare
vvagaytsev
force-pushed
the
applyArgs
branch
from
0f95f2b to
a8b41cc
Compare
|
Thank you @vvagaytsev your test looks much better than my. I was currently struggling with finding a check. First I was thinking about a --server-side, but my current approach to test it was to add a very large file which I did't like. A negative test like yours looks more promising and don't includes large files ❤️ |
|
@ManAnRuck thank you for spotting and fixing the bug! 👍 |
vvagaytsev
approved these changes
Sep 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add already prepared
applyArgsto KubeCtl'sapplyfunction 🫣Which issue(s) this PR fixes:
Fixes #3839
Patches #6107
Special notes for your reviewer:
i am a little bit lost where to add some tests. can someone give me a hint? 😊