fix(sync): ensure the sync daemon env is configured correctly #6302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure that `MUTAGEN_SSH_PATH` pointing to the faus ssh is always set when a native Mutagen daemon is used. Co-authored-by: Steffen Neubauer <[email protected]>
vvagaytsev
force-pushed
the
fix/mutagen-faux-ssh-path
branch
from
836c39a to
35b95db
Compare
stefreak
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Make sure that
MUTAGEN_SSH_PATHpointing to the faux ssh is always set when a native Mutagen daemon is used.Which issue(s) this PR fixes:
See the Discord thread.
Special notes for your reviewer:
This doesn't completely solve the original issue mentioned in the Discord. But, it ensures that the right version of the ssh binary (i.e. our own faux ssh binary) is used.