Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(container): first-class BuildKit secrets support #6294

Merged
merged 11 commits into from
Jul 18, 2024

Conversation

stefreak
Copy link
Member

@stefreak stefreak commented Jul 16, 2024

What this PR does / why we need it:
First-class BuildKit secrets support for BuildKit in-cluster building,
Garden Cloud Builder and building locally.

Kaniko is not supported due to lack of support (See also
GoogleContainerTools/kaniko#3028)

Which issue(s) this PR fixes:

Fixes #5479

Special notes for your reviewer:

@stefreak stefreak marked this pull request as draft July 16, 2024 15:29
First-class BuildKit secrets support for BuildKit in-cluster building,
Garden Cloud Builder and building locally.

Kaniko is not supported due to lack of support (See also
GoogleContainerTools/kaniko#3028)
@stefreak stefreak force-pushed the first-class-secrets branch from 5a8fded to 19f2056 Compare July 16, 2024 15:54
core/src/util/escape.ts Outdated Show resolved Hide resolved
@stefreak stefreak requested a review from vvagaytsev July 17, 2024 16:56
@stefreak stefreak marked this pull request as ready for review July 17, 2024 16:56
core/src/util/secrets.ts Outdated Show resolved Hide resolved
vvagaytsev
vvagaytsev previously approved these changes Jul 18, 2024
Copy link
Collaborator

@vvagaytsev vvagaytsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🚀
I left a couple of non-blocking comments

core/src/util/secrets.ts Outdated Show resolved Hide resolved
core/src/util/secrets.ts Outdated Show resolved Hide resolved
@stefreak stefreak added this pull request to the merge queue Jul 18, 2024
@stefreak stefreak removed this pull request from the merge queue due to a manual request Jul 18, 2024
@stefreak stefreak added this pull request to the merge queue Jul 18, 2024
Merged via the queue into main with commit 9e1ac29 Jul 18, 2024
41 checks passed
@stefreak stefreak deleted the first-class-secrets branch July 18, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Allow build time secrets
2 participants