improvement(core): fix missing action type err msg #6176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix, we'd erroneously list the available action kinds instead of the available action types (for the invalid action's kind). Fixes #5401.
stefreak
approved these changes
Jun 11, 2024
|
|
||
| const configPath = relative(garden.projectRoot, config.internal.configFilePath || config.internal.basePath) | ||
|
|
||
| if (!actionTypes[config.kind][config.type]) { | ||
| if (!actionTypes[kind][type]) { | ||
| const availableKinds: ActionKind[] = [] | ||
| actionKinds.forEach((actionKind) => { |
There was a problem hiding this comment.
I'd find k as variable name slightly less confusion here, as it would be easier to distinguish from the new kind variable name in the top level
| contains: [ | ||
| "Unrecognized action type 'invalidtype'", | ||
| "Currently available 'Build' action types: 'container', 'exec', 'test'", | ||
| "Are you missing a provider configuration?", |
There was a problem hiding this comment.
There is not a good page in the docs that introduces the concept of providers. The closest would probably be https://docs.garden.io/reference/project-config … should we still help the user a little bit here and ask them to have a look at the docs?
Can we find the provider names that provide the referenced action type and list them as well?
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Before this fix, we'd erroneously list the available action kinds instead of the available action types (for the invalid action's kind).
Which issue(s) this PR fixes:
Fixes #5401.