improvement(k8s): allow volume mounts in runners #6112
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
If a
kubernetes-pod
Run or Test includesvolumeMounts
on the first container in itspodSpec
, we now include this in the runner pod.Previously, we omitted the
volumeMounts
field from the first container in the (optional) user-suppliedpodSpec
field. This is because the relevant code assumedcontainer
Runs/Tests—it's now appropriate forcontainer
andkubernetes-pod
Runs/Tests.Which issue(s) this PR fixes:
Fixes #6069.