Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement(k8s): allow volume mounts in runners #6112

Merged
merged 1 commit into from
May 31, 2024

Conversation

thsig
Copy link
Collaborator

@thsig thsig commented May 30, 2024

What this PR does / why we need it:

If a kubernetes-pod Run or Test includes volumeMounts on the first container in its podSpec, we now include this in the runner pod.

Previously, we omitted the volumeMounts field from the first container in the (optional) user-supplied podSpec field. This is because the relevant code assumed container Runs/Tests—it's now appropriate for container and kubernetes-pod Runs/Tests.

Which issue(s) this PR fixes:

Fixes #6069.

@thsig thsig requested a review from edvald May 30, 2024 19:51
@edvald
Copy link
Collaborator

edvald commented May 30, 2024

Looks good at first glance, just have some tests there that need to be updated.

If a `kubernetes-pod` Run or Test includes `volumeMounts` on the first
container in its `podSpec`, we now include this in the runner pod.

Previously, we omitted the `volumeMounts` field from the first container
in the (optional) user-supplied `podSpec` field. This is because the
relevant code assumed `container` Runs/Tests—it's now appropriate for
`container` and `kubernetes-pod` Runs/Tests.
@thsig thsig force-pushed the include-volume-mounts-in-runner-pods branch from 1ae7c6e to e639ca4 Compare May 31, 2024 08:37
@thsig
Copy link
Collaborator Author

thsig commented May 31, 2024

Tests are green now, should be good to go.

@vvagaytsev vvagaytsev added this pull request to the merge queue May 31, 2024
Merged via the queue into main with commit bac234b May 31, 2024
41 checks passed
@vvagaytsev vvagaytsev deleted the include-volume-mounts-in-runner-pods branch May 31, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unclear overrides of kubernetes-pod podSpec fields
3 participants