feat: add maven-container plugin type #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thsig
approved these changes
Mar 8, 2019
| const mvnCmdStr = "mvn " + mvnArgs.join(" ") | ||
|
|
||
| log.setState(`Creating jar artifact...`) | ||
| await mvn(ctx.projectRoot, [ |
edvald
force-pushed
the
maven-container-plugin
branch
from
2304c66 to
7414898
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pushing this a little early, to support a customer. We'll want to add an example for this, and some further documentation.
This plugin is a specialised version of the container plugin, that adds a couple of parameters, and a pre-build step ahead of building the actual container. The motivation being that it's very difficult and/or prohibitively slow to build large Java projects inside containers, especially if they're organised in a way that doesn't jive with typical docker build context layouts.