feat(helm): store garden metadata in configmap instead of helm values #5827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvagaytsev
reviewed
Mar 14, 2024
vvagaytsev
requested changes
Mar 14, 2024
vvagaytsev
reviewed
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Store garden metadata for Helm deploy actions in a config map in the same namespace instead of adding them as additional values to the Helm release, which caused schema validation to fail for Helm charts with
additionalProperties: falsein thevalues.schema.json.Also fixes a skipped integration test on
localModefor Helm Charts by updating the example project from modules to actions.Which issue(s) this PR fixes:
Fixes #3962
Special notes for your reviewer: