Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): print ingress endpoints after deploying #575

Merged
merged 1 commit into from
Mar 1, 2019
Merged

feat(cli): print ingress endpoints after deploying #575

merged 1 commit into from
Mar 1, 2019

Conversation

edvald
Copy link
Collaborator

@edvald edvald commented Feb 27, 2019

Closes #502

@eysi09
Copy link
Collaborator

eysi09 commented Mar 1, 2019

Wondering if white looks better, although I could swing either way.

screenshot 2019-03-01 at 14 45 03

screenshot 2019-03-01 at 14 42 33

@edvald
Copy link
Collaborator Author

edvald commented Mar 1, 2019

I feel like it looks "better" aesthetically perhaps, but it draws my eye more than I think it should. I think I'll stick to it as is.

@edvald edvald force-pushed the show-endpoints-on-deploy branch from a788fb0 to a63c03e Compare March 1, 2019 14:45
@edvald edvald force-pushed the show-endpoints-on-deploy branch from a63c03e to b7961ec Compare March 1, 2019 15:52
@edvald edvald merged commit 9698808 into master Mar 1, 2019
@edvald edvald deleted the show-endpoints-on-deploy branch March 1, 2019 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eysi09 eysi09 eysi09 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edvald @eysi09