fix(git): fix file list caching bug for repo mode #5710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thsig
force-pushed
the
repo-scan-exclude-fix
branch
from
66d56ee to
622bbbf
Compare
This fixes an error that would come up e.g. when an action config in the project root excluded a subdirectory containing another action config. In that setup, the file list for the action in the subdirectory would be empty because the file list had been cached using the exclude config applied when computing the file list for the action config at the root level (which included no files for the excluded subdirectory). This was fixed by adding another level of caching to `GitRepoHandler` that accounts for different includes/excludes and filter functions for the same path.
thsig
force-pushed
the
repo-scan-exclude-fix
branch
from
622bbbf to
892719a
Compare
twelvemo
approved these changes
Feb 7, 2024
|
Just a note to link the related PR together. This fixed some filtering login implemented in #5526. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This fixes an error that would come up e.g. when an action config in the project root excluded a subdirectory containing another action config.
In that setup, the file list for the action in the subdirectory would be empty because the file list had been cached using the exclude config applied when computing the file list for the action config at the root level (which included no files for the excluded subdirectory).
This was fixed by adding another level of caching to
GitRepoHandlerthat accounts for different includes/excludes and filter functions for the same path.Special notes for your reviewer:
Note the slightly awkward clarification section about the difference between the exclude behavior of
subtreeandrepowhen no includes are configured.In a follow-up to this, we really should address #5582.
I think bringing our include/exclude behavior completely in line with Git's would make things easier to reason about for our users.