fix: don't emit taskPending if task is skipped #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edvald
reviewed
Feb 21, 2019
thsig
force-pushed
the
task-pending-event
branch
from
153350c to
d9196b2
Compare
|
Added a test case for this just now. |
edvald
approved these changes
Feb 22, 2019
This fixes an issue in TaskGraph where taskPending events were emitted for tasks with up-to-date cached results. This led to the task graph UI on the dashboard displaying the nodes corresponding to skipped tasks in a permanent pending state. This was addressed by only emitting the event if the task was, in fact, added to TaskGraph's index.
thsig
force-pushed
the
task-pending-event
branch
from
d9196b2 to
74e2c5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #540.
This fixes an issue in
TaskGraphwheretaskPendingevents were emitted for tasks with up-to-date cached results. This led to the task graph UI on the dashboard displaying the nodes corresponding to skipped tasks in a permanent pending state.This was addressed by only emitting the event if the task was, in fact, added to
TaskGraph's index.