improvement(logger): better provider resolution lifecycle logs #5464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eysi09 there are some test failures. Please check if those are caused by the changes made in the PR. |
This commits add more logging around the provider resolution phase of the Garden initialization. Also ensures that the log context passed to the plugin handlers has the provider name set.
eysi09
force-pushed
the
better-provider-logs
branch
from
a0a8896 to
0195796
Compare
Should be fixed now. |
vvagaytsev
approved these changes
Nov 21, 2023
eysi09
added a commit
that referenced
this pull request
Nov 21, 2023
Before this commit, our primary log color was chalk.grey and people generally agree that it's too vague. This commit changes the primary log color we've been using since we first released Garden to chalk.white for better accessibility and more fun. In general we can make this configurable. But I figured I'd just bite the bullet. See also discussion in: #5464
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 21, 2023
Before this commit, our primary log color was chalk.grey and people generally agree that it's too vague. This commit changes the primary log color we've been using since we first released Garden to chalk.white for better accessibility and more fun. In general we can make this configurable. But I figured I'd just bite the bullet. See also discussion in: #5464
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This commits add more logging around the provider resolution phase of the Garden initialization. Also ensures that the log context passed to the plugin handlers has the provider name set.
For context, these log improvements I've been making are part of the "getting started" video work. The idea there is to explain how Garden works and we need better lifecycle logging to support that.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: